Quick DW style help

I'm having a weird issue. In my DW comments, unexpanded comments are jumping in font size and I can't tell what the heck happened.







I checked my stylesheet and DW functions but can't work out why it jumps in size.

Or for that matter, why it has 'no subject' there and for that matter in regular font.

I will happily owe a favor to anyone who can help me work out where it all went wrong.

Comments

[azurelunatic]

roadrunnertwice has been trying to unfuck comment display recently, so stuff's been shifting behind the scenes.

If it's on Android, sometimes all the style stuff is fine but the browser has decided that this bit is more important and should be expanded (wtf).

[roadrunnertwice]

i am summoned 💀🌋

You're using a homemade layout AND theme (which means I at least can't have fucked with it directly), and I cannot for the life of me see anything in the recent core2 changes that would affect that font size/visibility.

Web inspector's not revealing anything visibly wonky in the CSS — actually there aren't any rules targeting the poster font size or the no-subject visibility.

Was this a recent regression? What browser(s) are you using? And also, can I get a look at your S2 layer sources?

[seperis]

Dude, this almost made me cry I'm so happy. You can have access to anything--how do I do that?

These are the current ones being used:
Layout layer ID: https://www.dreamwidth.org/customize/advanced/layerbrowse?id=962329
Theme layer ID: https://www.dreamwidth.org/customize/advanced/layerbrowse?id=982014

There was some customization for the following:
EntryPage::print_comment
EntryPage::print_comment_section
ReplyPage::print_comment

For ReplyPage, however, I looked at my test layout notes and remembered why I bothered with customizingit. I had to because of a similar font problem (blowing it up to 16) and I think fix reply box alignment. I did it after the customization of Entry Page::print_comment and ::print_comment_section, but at the time, at least, it didn't seem to be happening because of them.

The only new custom function is a footer (Entry::lay_print_efooter). That was created after the above three, however, and was only to create a css class to make a rounded-edge green box around metadata and tags and line them up more specifically. It shouldn't have affected anything else.

I have no idea if that information is useful or just like babbling. Sorry! I don't think it's anything you were doing, but something in here. I just can't work out where.

[roadrunnertwice]

OK, I'm looking at your layout source, I'm looking at the pages themselves, and I'm suspecting a browser cache issue or something.

Because the thing is, it all looks fine to me. I go looking for unexpanded comments in your archive, and they all look like this:

That's what you WANT them to look like, right? As in:

• All on a single line (if there's room for it, it'll wrap if needed).
• Subject is always visible (even if it's "(no subject)", because it serves as the permalink to the sub-thread).
• Font size on the whole line is the same (poster name isn't bigger).
• "From:" is hidden.

I'm seeing the styles that're intended to do that, I'm seeing them work as expected, all seems fine. So, question mark question mark? Anyway, I have some requests:

1. First, am I reading you right about what you expected to see, or am I missing something?
2. Can you link me to a page where this is currently happening for you?
3. Can you tell me what browser you're using, and whether it happens in all your browsers or just on one?
4. Can you blow away your browser cache and see if it's still happening after that?

(Also, if your browser supports it and if you're comfortable using the inspector, I'm real curious about what CSS rules you see if you right-click on something that's Wrong [like, the "From:" that isn't supposed to be there] and choose "inspect element." But that's bonus points, I know not everyone Loves 2 Inspect.)

[seperis]

Short version: browser cache. I literally hate everything.

(Long version: because I started frantically editing my style and now am not sure if I needed to and have to make a date to revert it and see. Like, I'm pretty sure I did some serious style hard coding that is probably not needed at all.)

Bless you. I actually do keep a clean browser just for testing (mostly my routers and my server) but it didn't occur to me to check my page there as technically, my brain did not consider 'DW checking and editing' a possible (read: EXCELLENT) use for it. Which is--IDEK.

[roadrunnertwice]

Yay! Well, I mean, I'm glad it's not anything truly awful, like serving different stylesheets to you vs. everyone else or something.

[seperis]

Adding: This did make me realize I have no idea what some of my CSS actually does now or if it does anything at all. Which is what happens when some parts were created back in S1 off the basic template, between then and S2 you forgot most of your CSS and so stole it from others and hoped for the best to get everything S2 compliant, then instead of doing a full refactoring (and say, relearning CSS) decided to learn how to make custom properties for colors and get custom text working on the sidebar. The latter, that was something I'd wanted to do for a while, but the former was basically because it was two AM and I honestly have no idea.

Disclaimer: I know CSS, but I haven't touched Dreamwidth styles in years

[flamebyrd]

Once I managed to find a page that had the bug, I did a little digging with the Firefox developer tools and it looks like your unexpanded comments have slightly different HTML than the expanded comments, so some of the CSS rules aren't being inherited and it just shows in the default font size.

So you can either adjust the HTML in your theme so that it's using the same class structure for both types of comment, or add a few new rules to your Custom CSS to account for the unexpanded comments too, orrr change the existing theme CSS so that it's a bit more general.

For the last option, for example, change:
.poster-information {
font-size: .75em;
}
to
.comment-poster {
font-size: .75em;
}
(If you add the second one without removing the first it will make the normal expanded comment usernames tiny.)

And then do something similar for .header .datetime, although this will require some testing because I don't know where else that rule is used.

Re: Disclaimer: I know CSS, but I haven't touched Dreamwidth styles in years

[seperis]

Huh. That would fit with my alteration of EntryPage::print_comment_section. I was saying above that I had to customize ReplyPage::print_comment because it suddenly ballooned in size.

I have a bad feeling that between 'locate problem in EntryPage::print_comment_section-related CSS' and 'customize literally every comment-related DW function' it may be easier to do the latter. I remember this driving me crazy before.

Thank you!

Re: Disclaimer: I know CSS, but I haven't touched Dreamwidth styles in years

[seperis]

I meant to come back; I'm (finally) trying to refactor my CSS and realized I don't know anymore how much of it is actually required, how much does absolutely nothing, how much should probably be consolidated, but also how much needs to be de-consolidated altogether.

Like, it's a toss up on how much I wrote myself, how much is standard DW, and how much I stole from other, prettier styles.

Re: Disclaimer: I know CSS, but I haven't touched Dreamwidth styles in years

[flamebyrd]

Yeeeah, refactoring CSS is one of those things that makes me realise why the current trend is to use newfangled CSS extension libraries to generate it all for you. (The need to learn how to use all these, plus the matching Javascript generators, is a major factor in why I am now Pursuing Alternative Career Options.)

I did just learn about the Chrome CSS Coverage tool though! https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage Looks like it could be helpful for figuring out what is and isn't being used, at least.